This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Update Octicons #13138
Merged
Update Octicons #13138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but still keep the old 2.1.2 version for backwards compatibility
git-diff seems to use `.octicon-font()`
So that text-align center still works
- beaker - bell - bold - desktop-download - ellipses - file - grabber - italic - logo-gist - plus-small - reply - shield - smiley - tasklist - text-size - thumbsdown - thumbsup - unverified - verified - watch
Closed
|
Btw. this will probably be the last update as "font icons" because the newer Octicons 5.0 only support SVG. And we should also move to SVG icons.. @joefitzgerald already got an etch version here: https://github.com/joefitzgerald/etch-octicon |
This was referenced Nov 4, 2016
|
Needs more padlocks:
Don't think we can ship with only four. |
Alhadis
added a commit
to file-icons/icons
that referenced
this pull request
Nov 12, 2016
* Octicons: This commit adds copies of certain Octicons visibly affected by Atom 1.13's upgrade to Octicons 4.4.0 (see atom/atom#13138): - Config/settings - Dashboard (used by Slim templates) - Image (default icon for media formats) - Tag (used for tagfiles) - Terminal (used for shell-scripts/misc executables) - Video (used for generic video formats) Codepoints match those used by Octicons, for the sake of symmetry. * SilverStripe: Codepoint chosen to match atom-silverstripe's icon-font. See gorriecoe/atom-silverstripe@2505984
peymanslh
pushed a commit
to peymanslh/welcome
that referenced
this pull request
Sep 3, 2017
This depends on atom/atom#13138 and atom/about/atom#43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Octicons to
4.4.0(almost newest). Some of the old icons from2.1.2that got removed in the meantime will still be available in Atom, so no packages should have missing icons.Here the 20 new icons that will be available:
Concerns
All icons should be fine except that the
GitHubwordmark is much smaller. We can update the font size in places where we use that icon, like on the About page. The "Gist" icon is also quite small, but since it's a new one, it hasn't been used anywhere.Remaining tasks:
Closes #8314
Will be in Atom
1.13